All committers have signed the CLA.

🤖 Beep Boop! This pull request is making changes to 'recipes/boost//'.

👋 @grafikrobot @Hopobcn @jwillikers @paulharris you might be interested. 😉

I detected other pull requests that are modifying boost/all recipe:

• boost: bump deps #23653
• boost: add version 1.85.0 #23569
• Boost Recipe: Update conanfile.py to use expected clang-win libprefix #21713
• boost: remove b2-default value of layout option #20336
• boost/<all versions>: error: Cannot configure toolset clang-win: no 'clang-cl.exe' command found or given #18764

This message is automatically generated by https://github.com/ericLemanissier/conan-center-conflicting-prs so don't hesitate to report issues/improvements there.

@kambala-decapitator Thank you for your PR! This current Boost recipe is linking to both zlib and bzip2 libraries present in Conan Center and is working. Why do you need these custom recipes instead of using the officials?

Plus, could you please share your full build log with your described error?

@kambala-decapitator Thank you for your PR! This current Boost recipe is linking to both zlib and bzip2 libraries present in Conan Center and is working. Why do you need these custom recipes instead of using the officials?

Plus, could you please share your full build log with your described error?

@uilianries I'd like to use system libraries - the less custom dependencies the better :) This has worked great with a few other libraries from CCI. I know that v2 has a built-in way to declare system libs, but currently our project is still using v1.

sorry, don't have the build log at hand any more, but initially it said something like "index out of bounds" pointing at the line

includedir = aggregated_cpp_info.includedirs[0].replace("\\", "/")

at first I modified my custom recipes to include library name in libs as well as empty string in includedirs and libdirs (arrays that access the first element) and boost built successfully, but then at cmake configure time it started complaining

-- Conan: Target declared 'BZip2::BZip2'
CMake Error at conan-generated/cmakedeps_macros.cmake:39 (message):
  Library 'bz2' not found in package.  If 'bz2' is a system library, declare
  it with 'cpp_info.system_libs' property
Call Stack (most recent call first):
  conan-generated/BZip2-Target-release.cmake:24 (conan_package_library_targets)
  conan-generated/BZip2Targets.cmake:26 (include)
  conan-generated/BZip2Config.cmake:16 (include)
  /usr/local/Cellar/cmake/3.29.1/share/cmake/Modules/CMakeFindDependencyMacro.cmake:76 (find_package)
  conan-generated/BoostConfig.cmake:24 (find_dependency)
  CMakeLists.txt:462 (find_package)

you can see full log at https://github.com/vcmi/vcmi/actions/runs/8637368273/job/23679378148

And with the current patch it all builds and works perfectly.

I'd like to use system libraries - the less custom dependencies the better :) This has worked great with a few other libraries from CCI. I know that v2 has a built-in way to declare system libs, but currently our project is still using v1.

@kambala-decapitator Sorry, I still miss the big picture, because you are actually using a Conan package for Boost, but can not use for zlib and bzip2? Those packages are built exactly as recommended by the upstream and most excepted in Linux distros, we usually compare patches from distros linux like Ubuntu and from AUR to make sure. Also, you can build from source all packages and inspect the recipe exported, in case you have security reasons. Is there something wrong with those packages that we could improve?

at first I modified my custom recipes to include library name in libs as well as empty string in includedirs and libdirs (arrays that access the first element) and boost built successfully, but then at cmake configure time it started complaining

Yes, packaging system libraries is a bit more complicated. You can use some recipes from CCI as reference:

• conan-center-index/recipes/glu/all/conanfile.py

  Line 31 in b229eb2

  def system_requirements(self):

• conan-center-index/recipes/gtk/system/conanfile.py

  Line 31 in b229eb2

  def system_requirements(self):

• conan-center-index/recipes/opengl/all/conanfile.py

  Line 25 in b229eb2

  def system_requirements(self):

you can see full log at vcmi/vcmi/actions/runs/8637368273/job/23679378148

Thank you for sharing!

@uilianries I've run into a similar problem elsewhere when using platform_requires for a system package. Trying to use cpp_info of system libraries can be problematic because the libs or certain other bits may not be set, at least when using platform_requires. Of course, this case appears to be a bit different.

@kambala-decapitator You might try setting the libs and libdirs variables appropriately. Ideally you could use pkg-config which handles transitive dependencies, but if I remember correctly, bzip doesn't provide one yet. They have one in master I think.

@uilianries I've run into a similar problem elsewhere when using platform_requires for a system package. Trying to use cpp_info of system libraries can be problematic because the libs or certain other bits may not be set, at least when using platform_requires. Of course, this case appears to be a bit different.

@jwillikers Thank you for your comment. Indeed accessing an index that could be empty is a bug, I'm not in the opposite of fixing the recipe in case having something broken. But first I would like to understand this scenario. When you mention a system package, did you refer a package like (e.g) gtk/system from ConanCenter?

@uilianries I've run into a similar problem elsewhere when using platform_requires for a system package. Trying to use cpp_info of system libraries can be problematic because the libs or certain other bits may not be set, at least when using platform_requires. Of course, this case appears to be a bit different.

@jwillikers Thank you for your comment. Indeed accessing an index that could be empty is a bug, I'm not in the opposite of fixing the recipe in case having something broken. But first I would like to understand this scenario. When you mention a system package, did you refer a package like (e.g) gtk/system from ConanCenter?

In my case, I had to add the include directories from the cpp_info of the linux-headers-generic package as part of the setup in the generate method of a package. When I used a platform_requires to use the system's Linux headers, accessing the include directories for it failed.

@uilianries @jwillikers thank you for the responses!

you are actually using a Conan package for Boost, but can not use for zlib and bzip2?

Apple OSs have these libraries in the system (I also have custom recipes to wrap iconv and sqlite3 btw) and I want to use them instead of building them from source. It's common practice in Apple world to use these built-in libraries in programs. I don't think that I must use them from CCI only?

Yes, packaging system libraries is a bit more complicated. You can use some recipes from CCI as reference:

these examples install something from package managers. I don't need this, all the aforementioned libs are present in a freshly installed OS.

You might try setting the libs and libdirs variables appropriately

yes, that's what I tried initially. But once I set libs, then cmake configuration of my project fails, see #23478 (comment)

btw I've just thought of this: would it make more sense to adjust the patch to check if system_libs is present and return empty string in that case?

P.S. Do I need to take any action because of the unexpected build error?

@uilianries please check my above comment

Conan v1 pipeline ✔️

All green in build 7 (6a049044f02fa89fae38e9b0325beb53bf23b66e):

• boost/1.83.0:
  All packages built successfully! (All logs)

• boost/1.79.0:
  All packages built successfully! (All logs)

• boost/1.81.0:
  All packages built successfully! (All logs)

• boost/1.78.0:
  All packages built successfully! (All logs)

• boost/1.84.0:
  All packages built successfully! (All logs)

• boost/1.76.0:
  All packages built successfully! (All logs)

• boost/1.75.0:
  All packages built successfully! (All logs)

• boost/1.74.0:
  All packages built successfully! (All logs)

• boost/1.72.0:
  All packages built successfully! (All logs)

• boost/1.71.0:
  All packages built successfully! (All logs)

• boost/1.80.0:
  All packages built successfully! (All logs)

• boost/1.73.0:
  All packages built successfully! (All logs)

• boost/1.82.0:
  All packages built successfully! (All logs)

• boost/1.77.0:
  All packages built successfully! (All logs)

Conan v2 pipeline ✔️

Note: Conan v2 builds are now mandatory. Please read our discussion about it.

All green in build 7 (6a049044f02fa89fae38e9b0325beb53bf23b66e):

• boost/1.84.0:
  All packages built successfully! (All logs)

• boost/1.83.0:
  All packages built successfully! (All logs)

• boost/1.81.0:
  All packages built successfully! (All logs)

• boost/1.82.0:
  All packages built successfully! (All logs)

• boost/1.80.0:
  All packages built successfully! (All logs)

• boost/1.77.0:
  All packages built successfully! (All logs)

• boost/1.78.0:
  All packages built successfully! (All logs)

• boost/1.71.0:
  All packages built successfully! (All logs)

• boost/1.73.0:
  All packages built successfully! (All logs)

• boost/1.72.0:
  All packages built successfully! (All logs)

• boost/1.74.0:
  All packages built successfully! (All logs)

• boost/1.75.0:
  All packages built successfully! (All logs)

• boost/1.79.0:
  All packages built successfully! (All logs)

• boost/1.76.0:
  All packages built successfully! (All logs)

Apple OSs have these libraries in the system (I also have custom recipes to wrap iconv and sqlite3 btw) and I want to use them instead of building them from source. It's common practice in Apple world to use these built-in libraries in programs. I don't think that I must use them from CCI only?

@kambala-decapitator Thank you for more details about your case. Could please refer a source about this common practice in Apple world? I've never heard about, so I'm curious. The problem using system dependencies is tracking the changes and reproducing the same build with total safety. You are totally free to mix Conan packages with system packages at your risk, if this enough to cover your case, so is totally fine :)

@uilianries thanks for the merge!

I don't have a source in the sense of an article from documentation, but if you open any Xcode project and go to the Link Binary With Libraries section, you can select a wide range of system libraries (besides frameworks) there, see SS. When one works purely with Xcode project, it's common to choose libraries from there.